On Thu, Nov 29, 2018 at 10:24 AM Peilke, Hendrik <hendrik.pei...@ibykus.de>
wrote:
> Hi Andrea,
>
>
>
> thanks for your answer. I think the basic design of the ifs (up until
> filtering) is correct: Since the DiffFeatureReader can filter and sorts out
> the modified features filtered by the native reader. Passing the query
> fixed our bug, which was only connect to filtering.
>
>
>
> If I understood you correctly, with
>
>
>
> if(!canTransact() && transaction != null && transaction !=
> Transaction.AUTO_COMMIT)
> { notAbleToDoAdvancedOperations = true; }
>
>
>
> the other blocks must be changed to
>
>
>
> if( … || notAbleToDoAdvancedOperations) { … }
>
>
>
> right?
>
Something like that, but "advanced operations" is generic, I'd give it a
more mearningful name,
like supportsCurrentTransaction or something like that.
> But for the filter block it is not needed, if the query is passed to the
> DiffFeatureReader, correct?
>
I see now that DiffFeatureReader can accept a Filter (I'm not the author of
these classes, nor familiar with them).
If that part works properly, then yes, you can just pass the filter.
It's a significan "if", however, I see only the wfs store using
the DiffFeatureReader constructor, don't think it's used much.
I don't even see an explicit test for it...
Should I make a pull request for that?
>
If you can take time to study the code and verify it actually works, or at
least guard it with enough tests, even just in the
ShapefileDataStore module, then yes, otherwise I'd stay on the safe side
and use the FilteringFeatureReader wrapper.
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information. == Ing. Andrea Aime @geowolf Technical Lead
GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39
0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
------------------------------------------------------- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
