Please merge, the more screws tight the less wobble in the table. On Tue, Jan 15, 2019 at 1:11 AM Andrea Aime <[email protected]> wrote:
> Hi, > last week reviewing a pull request I've found a number of empty lines of > code, just a ";" standing there alone. > Did not say anything, but wondered if PMD could not help dtetecting those. > > During the weekend (and a bit yesterday evening) I've switched PMD > priority filters from 2 down to 3, thus > enabling more rule checks (many of the rules in the PMD config file are > priority 3). I've found I could not > handle them all, so commented out a bit in the config files, but left most > of those relating to empty statements, > empty loops, empty if branches, unused fields, private methods and > variables, along with a few more > (going by memory, inefficient istantiation of BigDecimal, mixing up index > variables in loops, not checking Resltset.next() call). > > The result is here: > https://github.com/geotools/geotools/pull/2227 > > Not sure if I'll be able to make a matching working on GWC and GS, but > believe this is useful anyways. > Objections to merge? :-) > > Cheers > Andrea > > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- -- Jody Garnett
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
