Agreed, rendering artifacts are not worth supporting the
 symbol-avoid-edges: false case. This is one instance where we shouldn't
try and match server-side behavior with client-side.

Since this does mean that the "symbol-avoid-edges" rule won't have any
effect server-side, it should also be marked as not supported in our GT
MBStyle spec (even though it's effectively "always-on" instead of
"always-off").

Cheers,
Torben



On Wed, Dec 11, 2019 at 2:21 AM Andrea Aime <andrea.a...@geo-solutions.it>
wrote:

> Hi,
> I'm looking at a tiled map generated via MBTiles + MBSTyles and getting
> this output:
>
> [image: image.png]
>
> Notice the two cut labels, should have been "Piano di Mommio" and "SR439".
> This is happening because by default Mapbox Styles allow labels to cross
> tile borders:
>
> https://docs.mapbox.com/mapbox-gl-js/style-spec/#layout-symbol-symbol-avoid-edges
> And there is a lengthly explanation of why it's done also in the code:
>
> https://github.com/geotools/geotools/blob/master/modules/unsupported/mbstyle/src/main/java/org/geotools/mbstyle/layer/SymbolMBLayer.java#L1855
>
> Except that the output above is not acceptable... and I believe we should
> just ignore the setting, because
> the context is just not the same. In client side rendering, a label will
> not be cut, it can still be painted fully,
> worst case it's going to overlap with some other labels.
> Server side instead, there is no setting to force the appearance of the
> label in the other tile, they are produced
> independently and are working against different geometries (clipping).
>
> Opinions?
>
> Cheers
> Andrea
>
> == GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
> http://www.geo-solutions.it http://twitter.com/geosolutions_it
> ------------------------------------------------------- *Con riferimento
> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
> circostanza inerente alla presente email (il suo contenuto, gli eventuali
> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
> sarei comunque grato se potesse darmene notizia. This email is intended
> only for the person or entity to which it is addressed and may contain
> information that is privileged, confidential or otherwise protected from
> disclosure. We remind that - as provided by European Regulation 2016/679
> “GDPR” - copying, dissemination or use of this e-mail or the information
> herein by anyone other than the intended recipient is prohibited. If you
> have received this email by mistake, please notify us immediately by
> telephone or e-mail.*
> _______________________________________________
> GeoTools-Devel mailing list
> GeoTools-Devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to