In reviewing https://github.com/geotools/geotools/pull/2732 the proposed
geotools template has a note about commit messages.

This conflicts with my habit of short descriptive commit messages on other
projects so I consistently run up against this in PRs for GeoServer. When
making a pull request I quote the ticket number in the PR description, but
not in the individual commit messages.

What is the advantage of this format? Does it come from an automatic tool?

On the PR Andrea offers:

*I need to have at least the ticket number in full, helps finding if a
ticket has been worked on or not (there are many tickets forgotten
un-closed) and for cross linking to Jira. The title helps too, it's a clear
description and the one that user see in the release notes.*


I can see those advantages, I tend to capture bug fixes at the PR level to
meet that need.
--
Jody Garnett
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to