On Sat, Feb 1, 2020 at 9:40 PM Jody Garnett <jody.garn...@gmail.com> wrote:
> Thanks for the updates. > > I have another in progress about RGBA color handling (Mapbox GL handles >> opacity with both the color spec and the opacity, the >> translator only uses the latter)... I have a work in progress that uses >> functions to move around the color in its full RGBA form, >> needs a bit more tests, but first wanted to check if the road is >> acceptable, or if we should extract the alpha from the color >> and multiply it with the explicit opacity in the fill-opacity, >> stroke-opacity settings instead (seems harder and more convoluted to me...). >> > > I wrestled with this back when outlining the initial project. > > I would rather the internals of mbstyle module be "harder and more > convoluted") then to force complexity on the render and the other formation > encoders/parsers. > > That said the render appears to already support RGBA colors, so I expect > we have an rgba + opacity to consider everywhere > - ColorConverterFactory.java > <https://github.com/geotools/geotools/blob/0e49d4257a7edb54053ccaa85d7f8aec5f0dc144/modules/library/main/src/main/java/org/geotools/data/util/ColorConverterFactory.java#L78> > - IntegerRgbAccessor.java > <https://github.com/geotools/geotools/blob/master/modules/library/render/src/main/java/org/geotools/renderer/composite/IntegerRgbAccessor.java> > > Yes Java2D itself does it for us, since we pass a Color, whatever it is, might be including alpha, and then a composite, so they are orthogonal. Your comment is not very clear in terms of direction, but I'm guessing you're good with the current approach, once those classes handle alpha properly? The IntegerRgbAccessor already does, the section you pointed in the ColorConverterFactory also does so... confused again :-D Cheers Andrea -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
