Subject to what Andrea says it sounds good to me (I think I'm the module maintainer but I could be wrong) - go for a PR and I'll try to review it and pitch in as I get time.
Ian On Tue, 11 Feb 2020 at 17:03, Andrea Aime <andrea.a...@geo-solutions.it> wrote: > Hi, > just an observation, checking the geopackage extensions, I see one from > the GeoPackage spec author, called "Styling and symbology extension" > and another, probably the one you're talking about, called "QGIS Map > Styling Information". > See: https://www.geopackage.org/extensions.html > > They probably don't match, but if there is a single public GeoTools API > talking about gpkg styles, it should be able to eventually handle both. > I'm not saying that you have to implement them both, but a public API in > the GeoPackage classes should > be able to expose both transparently, or else be explicit and have a way > to extract QGIS styles and > "geopackage styles" in a separate way > > Cheers > Andrea > > > On Tue, Feb 11, 2020 at 5:53 PM Henning, Mark (Peraton) (US Person) via > GeoTools-Devel <geotools-devel@lists.sourceforge.net> wrote: > >> Good Morning, >> >> >> >> QGIS allows a layer’s style to be stored in a GeoPackage (or other >> database oriented solutions). It creates a table called layer_styles which >> contains metadata, the QGIS proprietary layer style information , but also >> a column which contains an SLD. >> >> >> >> I would like to add methods to the org.geotools.geopkg.GeoPackage class >> to be able to access this information. >> >> Looking at how the class is already designed, I would suggest the >> following >> >> >> >> A new class: StyleEntry (with appropriate getters) >> >> { >> >> Entry entry; // the entry to which the style belong >> >> String name; // the contents of the styleName column >> >> String description; // the contents of the description >> column >> >> } >> >> >> >> Then add the following methods to GeoPackage >> >> >> >> List<StyleEntry> layerStyles(); >> >> Style layerStyles(StyleEntry entry); >> >> >> >> Although I would like to support adding a layer style, the layer_styles >> table stores both the SLD and QML versions of the style description, and >> until the rest of GeoTools supports QML styles that would leave the >> database row created for the new storage inconsistent with rows created >> from QGIS. >> >> >> >> If there is another way to reasonably pull this information from a >> GeoPackage, I am open to other solutions. >> >> >> >> Would this added feature be amenable to the developer community? >> >> >> >> Very respectfully, >> >> >> >> *Mark Henning* >> >> Software Engineer, Technical Specialist >> >> Nuclear Science & Engineering >> >> Office: 719-599-1519 >> >> Cell: 612-703-8563 >> >> [image: cid:image001.png@01D3C5CF.995E1BA0] >> >> >> _______________________________________________ >> GeoTools-Devel mailing list >> GeoTools-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > > > -- > > Regards, Andrea Aime == GeoServer Professional Services from the experts! > Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime > @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 > Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 > 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Ian Turton
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
