That is a really good step, thank you Andrea. For GeoPackage I think we could make those tests on by default (not Online) and trust anyone building on a non major platform build that module without tests.
On Sun, Mar 22, 2020 at 10:02 AM Andrea Aime <andrea.a...@geo-solutions.it> wrote: > Hi, > while working on a fix for the GeoPackage store I realized the tests for > it were broken, > and are not running by default, as they are considered online tests. > That makes sense, as the native libraries necessary to run the tests are > available "only" for three > major OSs I believe (personally I can only confirm they work on Linux). > > So, while fixing the previously broken tests, I've also added a build > check for it, so that geopkg > tests are run as PR checks: > https://github.com/geotools/geotools/pull/2845 > > Since it seemed to work fine, I've also created an equivalent for PostGIS, > here: > https://github.com/geotools/geotools/pull/2846 > > More could be added for other data sources (relational or not) requiring a > online test setup. > The system works by using docker images, thought it seems a bit convoluted > (one has to create an > action that runs the docker image, as opposed to just starting it). > I don't intend to add more checks right now, but one can hope others will > chime in, if they care and have time :-p > > I also don't know if having many builds is a good idea in terms of PR > build times... in theory > they build in parallel, but I don't know if Github poses a limit to the > number of concurrent > builds an organization can run (might seem like an obvious thing to do). > > Anyhow, if there are no objections, I'm going to merge the two PRs above > and we > can see how they work for us > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > <https://www.google.com/maps/search/Via+di+Montramito+3%2FA%0D%0A55054++Massarosa?entry=gmail&source=g> > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- -- Jody Garnett
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
