On Thu, Apr 23, 2020 at 3:08 AM David Jerrard <djerr...@gmail.com> wrote:

>
> *WORKING SOLUTION*
> I have already confirmed (?) that the code change required to implement
> this change in the gt-jdbc-oracle extension is minimal:
>
>
> https://github.com/geotools/geotools/compare/22.2...djerrard:djerrard_oracle_filter?expand=1
>

The approach looks good.


> *WHAT'S NEXT?*
>
>    - I have never been here before
>    - I am not a java developer, so unable to provide any useful technical
>    contribution in that capacity
>    - I would obviously like to see this change incorporated into the
>    Geotools code base - possibly augmented with other similar Oracle plugin
>    enhancements (are there any others on the "wish list"?)
>
> It is my impression that all existing core developers are "fully spent",
cannot really do more than they already do in their spare time.
So, in order to incorporate a change in GeoTools, the interested parties
need act mostly alone (or go for commercial support, allowing
devs to use work hours instead). I also have the impression that commercial
databases are in particular supported mostly on a "per contract" basis.

What you miss in the change above is a test, I believe the postgis store
test already contain a test for strToLowerCase that you can
copy from, see JDBCFunctionOnlineTest
<https://github.com/geotools/geotools/blob/1803f2d2c91f46de0487f483d32f1507c9eb3b27/modules/library/jdbc/src/test/java/org/geotools/jdbc/JDBCFunctionOnlineTest.java#L41>
and its subclasses... that assesses multiple functions, you could just use
it as an example,
or subclasses and mark most tests as @Ignore.

Cheers
Andrea

== GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
(LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
------------------------------------------------------- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to