then sounds like all you need is a +1 so you are good to go
On Fri, 16 Oct 2020 at 16:54, Joseph Miller <bg...@yahoo.com> wrote: > Yes, I did one for myself prior to contributing some bug fixes a few > months ago. > > Joe > > On Fri, Oct 16, 2020 at 11:49 AM Ian Turton <ijtur...@gmail.com> wrote: > >> Have you (or your employer) filled in a code contribution agreement? - >> https://docs.geotools.org/latest/developer/procedures/contribution_license.html >> >> >> I think we still need one even for unsupported modules >> >> Ian >> >> On Fri, 16 Oct 2020 at 16:24, Joseph Miller via GeoTools-Devel < >> geotools-devel@lists.sourceforge.net> wrote: >> >>> As discussed in this email chain and in the GitHub PR comments section ( >>> https://github.com/geotools/geotools/pull/3161 ) I would like to >>> request commit access of the cql-json community module of which I'll be >>> the maintainer. I agree to follow the standards described in >>> https://docs.geotools.org/latest/developer/procedures/create.html and >>> other applicable procedures/standards. >>> >>> Thanks, >>> Joe Miller ( https://github.com/turingtestfail ) >>> >>> On Tue, Sep 29, 2020 at 1:49 PM Jody Garnett <jody.garn...@gmail.com> >>> wrote: >>> >>>> Great, I am looking forward to this functionality and it looks good. >>>> >>>> The only real requirement >>>> <https://docs.geotools.org/latest/developer/procedures/create.html> at >>>> this time is that you do not break the build, I will merge now. >>>> >>>> Unsupported modules are tagged with each release (in source code) but >>>> are not built until they have been put forward as ready for being included >>>> in the geotools library. >>>> We can set it up so your module is compiled (so snapshots are available >>>> in maven for your QA) but they do not become part of the release bundle. >>>> >>>> When you are ready the next step should be in our developer guide >>>> <https://docs.geotools.org/latest/developer/procedures/supported.html>. >>>> -- >>>> Jody Garnett >>>> >>>> >>>> On Tue, 29 Sep 2020 at 08:12, Joseph Miller <bg...@yahoo.com> wrote: >>>> >>>>> Thanks for the feedback. I made most of the changes suggested. Since >>>>> this is an unsupported module is there a still procedure for it to get >>>>> included in the next release? >>>>> >>>>> Thanks, >>>>> Joe Miller >>>>> >>>>> On Thu, Sep 24, 2020 at 5:14 PM Jody Garnett <jody.garn...@gmail.com> >>>>> wrote: >>>>> >>>>>> Thanks, that is interesting, some feedback provided. >>>>>> -- >>>>>> Jody Garnett >>>>>> >>>>>> >>>>>> On Thu, 24 Sep 2020 at 12:49, Joseph Miller <bg...@yahoo.com> wrote: >>>>>> >>>>>>> I have created an unsupported module for basic conversion of >>>>>>> CQL-JSON into GeoTools Filters as discussed and am looking for >>>>>>> feedback/guidance. The PR for the module can be found at >>>>>>> https://github.com/geotools/geotools/pull/3161 >>>>>>> >>>>>>> Joe Miller >>>>>>> >>>>>>> On Mon, Aug 31, 2020 at 2:39 AM Andrea Aime < >>>>>>> andrea.a...@geo-solutions.it> wrote: >>>>>>> >>>>>>>> Hi Joseph, >>>>>>>> there is no one working on the cql-json implementation, feel free >>>>>>>> to work on it. >>>>>>>> >>>>>>>> Last I checked there were two JSON based approaches, one >>>>>>>> hierarchical, one array based, was there any >>>>>>>> decision taken in that regard? >>>>>>>> Looking at this page, it would seem not: >>>>>>>> >>>>>>>> https://github.com/opengeospatial/ogcapi-features/blob/master/extensions/cql/standard/clause_10_encodings.adoc >>>>>>>> Quoting: >>>>>>>> >>>>>>>> Attention is drawn to the fact that there exists an alternative >>>>>>>> JSON encoding for CQL based on the use of arrays that can be found >>>>>>>> here: >>>>>>>> https://github.com/tschaub/ogcapi-features/tree/json-array-expression/extensions/cql/jfe. >>>>>>>> The SWG will need to review both encodings and decide which one to >>>>>>>> adopt. >>>>>>>> >>>>>>>> >>>>>>>> Since there is nothing final yet, I would recommend setting up a >>>>>>>> gt-cql-json community module where you can implement >>>>>>>> the variant of your liking (or even both). >>>>>>>> >>>>>>>> Cheers >>>>>>>> Andrea >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Aug 31, 2020 at 3:47 AM Jody Garnett < >>>>>>>> jody.garn...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Gabe did the initial work if I remember, but that was a long while >>>>>>>>> ago, please feel free to dive in! >>>>>>>>> -- >>>>>>>>> Jody Garnett >>>>>>>>> >>>>>>>>> >>>>>>>>> On Sat, 29 Aug 2020 at 12:07, Joseph Miller via GeoTools-Devel < >>>>>>>>> geotools-devel@lists.sourceforge.net> wrote: >>>>>>>>> >>>>>>>>>> I am interested in contributing some hours on keeping GeoTools' >>>>>>>>>> CQL to Filter capabilities up to speed on what is going on with the >>>>>>>>>> OGC >>>>>>>>>> Common Query Language 3.0 spec, particularly the CQL JSON stuff ( >>>>>>>>>> https://github.com/opengeospatial/ogcapi-features/tree/master/extensions/cql >>>>>>>>>> ) >>>>>>>>>> Is there currently a person who has taken the lead on that effort >>>>>>>>>> that I >>>>>>>>>> should talk to? >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Joe Miller >>>>>>>>>> _______________________________________________ >>>>>>>>>> GeoTools-Devel mailing list >>>>>>>>>> GeoTools-Devel@lists.sourceforge.net >>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>>>>>>> >>>>>>>>> _______________________________________________ >>>>>>>>> GeoTools-Devel mailing list >>>>>>>>> GeoTools-Devel@lists.sourceforge.net >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> Regards, Andrea Aime >>>>>>>> >>>>>>>> == GeoServer Professional Services from the experts! Visit >>>>>>>> http://goo.gl/it488V for more information. == Ing. Andrea Aime >>>>>>>> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 >>>>>>>> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 >>>>>>>> 339 >>>>>>>> 8844549 http://www.geo-solutions.it >>>>>>>> http://twitter.com/geosolutions_it >>>>>>>> ------------------------------------------------------- *Con >>>>>>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>>>>>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>>>>>>> precisa che ogni circostanza inerente alla presente email (il suo >>>>>>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>>>>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>>>>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>>>>>> operazione è illecita. Le sarei comunque grato se potesse darmene >>>>>>>> notizia. >>>>>>>> This email is intended only for the person or entity to which it is >>>>>>>> addressed and may contain information that is privileged, confidential >>>>>>>> or >>>>>>>> otherwise protected from disclosure. We remind that - as provided by >>>>>>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of >>>>>>>> this >>>>>>>> e-mail or the information herein by anyone other than the intended >>>>>>>> recipient is prohibited. If you have received this email by mistake, >>>>>>>> please >>>>>>>> notify us immediately by telephone or e-mail.* >>>>>>>> >>>>>>> _______________________________________________ >>> GeoTools-Devel mailing list >>> GeoTools-Devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/geotools-devel >>> >> >> >> -- >> Ian Turton >> > -- Ian Turton
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
