Hi Andreas, this is just my personal opinion, others might want to chime in. Since MultithreadedHttpClient depends on Commons HTTPclient I would suggest avoiding gt-main.
I see we're still depending on commons-httpclient 3.1 there, which is not awfully large, 300k give or take, and two more depds of it, commons logging and commons-codec, which push the total to 400k, none of them being currently a gt-main dependency. Instead, I would suggest to make it into its own plugin module, probably under plugin or extensions (suggestions?), that provides this functionality, and both gt-wms and gt-wfs can depend on it, in turn. Cheers Andrea On Thu, Oct 29, 2020 at 12:54 PM Watermeyer, Andreas < andreas.waterme...@its-digital.de> wrote: > Hi all, > > > > I recently raised an issue because the GT WFS HTTPClient respects the > proxy settings only partially. It ignores the “nonProxyHosts” settings: > > https://osgeo-org.atlassian.net/browse/GEOT-6727 > > > > I then realized, that the class MultithreadedHttpClient exists in the WMS > and in the WFS module, as copies. WMS was already extended to support > nonProxyHosts and also Gzip compression. > > Ideally both will be merged into one again. > > > > Q: Which module could take the common implementation? Maybe gt-main? I > think it is the only dependency the WMS and WFS module have in common. > > Or do you prefer to keep the separat copies of the class to have keep the > modules less coupled? > > > > I can offer a pull request but I need a direction to go… > > > > Best regards, > > Andreas > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
