I am aware, I git blamed it too. But I just cannot recall or see any
reason why I did this. Ben seems to have missed it too, he even made a
comment "this is pretty thorough unit test coverage"... My guess would
be that it is a mistake. Thanks to Brad for finding it.
Kind Regards
Niels
On 04/04/2022 10:43, Andrea Aime wrote:
Hi Niels,
Brad is correctly asking you, since you added that test, and you also
ignored it, a few months later, in these two commits:
image.png
Daniele would be the maintainer, but he was away in honeymoon and
could not review the PR that ignored the test,
which was reviewed by Ben instead, see here:
https://github.com/geotools/geotools/pull/1531
That said... the test is passing so I guess we could just keep it, and
yes, use commons-compress to unpack the tar.gz,
or maybe even better, just change sampledata.tar.gz to smapledata.zip...
Cheers
Andrea
On Sat, Apr 2, 2022 at 2:42 PM Niels Charlier via GeoTools-Devel
<geotools-devel@lists.sourceforge.net> wrote:
Hello Brad,
I do not recall why the test was ignored. It actually seems to
work when
I try so I wouldn't personally remove it.
I have to say I don't remember much about this module any more,
and I do
not use it. Since it is a plugin I suppose someone is maintaining it?
Kind Regards
Niels
On 02/04/2022 05:29, Brad Hards wrote:
>
https://github.com/geotools/geotools/blob/main/modules/plugin/coverage-multidim/netcdf/src/test/java/org/geotools/coverage/io/netcdf/
> NetCDFMultiDimTest.java#L67 is turning off testing (since 2017).
>
> Should the test be removed, or is something required?
>
> This came up because it looks like this is the only use of the
plexus-
> archiver, which is a bit old. If it goes, we can remove that
test dep, or if
> its still needed we can switch to something less involved, like
commons-
> compress.
>
> Brad
>
>
>
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Regards,
Andrea Aime
==GeoServer Professional Services from the experts!
Visit http://bit.ly/gs-services-us <http://bit.ly/gs-services-us>for
more information.==Ing. Andrea Aime @geowolfTechnical Lead
GeoSolutions Groupphone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
https://www.geosolutionsgroup.com/ <https://www.geosolutionsgroup.com/>
http://twitter.com/geosolutions_it <http://twitter.com/geosolutions_it>
-------------------------------------------------------
Con riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati
“GDPR”), si precisa che ogni circostanza inerente alla presente email
(il suo contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a
cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato
se potesse darmene notizia.This email is intended only for the person
or entity to which it is addressed and may contain information that is
privileged, confidential or otherwise protected from disclosure. We
remind that - as provided by European Regulation 2016/679 “GDPR” -
copying, dissemination or use of this e-mail or the information herein
by anyone other than the intended recipient is prohibited. If you have
received this email by mistake, please notify us immediately by
telephone or e-mail
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
