Good question, yes it works like in CSS and it's mostly handled here:
https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/style/SLDStyleFactory.java#L1127
https://github.com/geotools/geotools/blob/main/modules/library/render/src/main/java/org/geotools/renderer/VendorOptionParser.java#L114
So in markToTilableImage() the margin is either null or an array of 4 ints
On 12/19/23 4:38 PM, Jody Garnett wrote:
That looks good; and the change to the reference image covers your
need for a test case.
Question: you assume the margin is an array of 4 numbers.
Does it work like with CSS where an array of a single number, or an
array of two numbers could be provided?
--
Jody Garnett
On Tue, Dec 19, 2023 at 7:33 AM Cécile Vuilleumier
<cecile.vuilleum...@camptocamp.com> wrote:
Hi all
I am back again on the topic of polygon fill with repeated markers
(see https://osgeo-org.atlassian.net/browse/GEOT-7357)
Unfortunately my fix did introduce an unwanted side effect: if the
given margin is greater than the marker size, an error is thrown
and the layer is not drawn:
org.geotools.renderer.lite: x lies outside raster -> it happens
on this line
<https://github.com/geotools/geotools/blob/9df403d52baf8f099d8d9569b7399a1b1906568a/modules/library/render/src/main/java/org/geotools/renderer/style/SLDStyleFactory.java#L1263>
Here is a proposed fix:
https://github.com/vuilleumierc/geotools/commit/b94415a586fdb86a923b072a9ad26af92c83b278
Is it OK for me to open an issue and a PR?
Cheers, Cécile
--
*camptocamp*
*Cécile Vuilleumier
*
Geospatial developer
www.camptocamp.com <http://www.camptocamp.com>
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
