Hello James, hello all,

I have been playing with the project.xml again and noticed two things:

- Shouldn't the unitTests also include **/*Test.java instead of only
**/*TestCase.java ?
- Wouldn't it be nice to list Junit as dependency (even though not really
required for maven) ?

Patch is attached.

Thanks,

Steffen Schluff

-----Ursprungliche Nachricht-----
Von: James Strachan [mailto:[EMAIL PROTECTED]
Gesendet: Dienstag, 12. August 2003 10:01
An: [EMAIL PROTECTED]
Betreff: Re: cvs commit: incubator-geronimo maven.xml



On Monday, August 11, 2003, at 08:42  pm, Christian Trutz wrote:

> hi commiters,
>
> thanx for the "run" goal!
>
> the "modules/core/src/conf" path should be also added to the test
> classpath,
> i am writing some junit test cases and log4j.properties is not loaded
> automatically.

Its fixed now - the new Main doesn't require any command line arguments.

James
-------
http://radio.weblogs.com/0112098/
Index: project.xml
===================================================================
RCS file: /home/cvspublic/incubator-geronimo/project.xml,v
retrieving revision 1.6
diff -u -r1.6 project.xml
--- project.xml 12 Aug 2003 07:57:55 -0000      1.6
+++ project.xml 12 Aug 2003 08:07:10 -0000
@@ -206,6 +206,13 @@
             <id>mx4j+tools</id>
             <version>SNAPSHOT</version>
         </dependency>
+
+        <dependency>
+            <id>junit</id>
+            <version>3.8.1</version>
+            <url>http://www.junit.org/</url>
+        </dependency>
+
     </dependencies>
 
     <build>
@@ -218,6 +225,9 @@
         <sourceDirectory>${basedir}/modules/core/src/java</sourceDirectory>
         
<unitTestSourceDirectory>${basedir}/modules/core/src/test</unitTestSourceDirectory>
         <unitTest>
+            <includes>
+                <include>**/*Test.java</include>
+            </includes>
             <includes>
                 <include>**/*TestCase.java</include>
             </includes>

Reply via email to