Hi Jason, Issue is a real simple one.
Ed previously suggested that when submitting /new/ files with a patch, the new files should be stored in a jar file (to rpeserve directory structure and platform independenc) and attached to the [PATCH] email along with the patch.txt file generated by "cvs diff -u" (which only contains the directory diff information). I think James then 'accepted' this suggestion as the way for non-comitters to submit new files. However, what was not specified in the original agreement was the format of the jar file. Here's a really verbose explanation that should bore the socks off you ;) Say my src is at /usr/local/src/incubator-geronimo Say I want to add /usr/local/src/incubator-geronimo/modules/core/src/test/org/apache/geronimo/cache/SimpleInstancePoolTest.java Should I do "jar -cvf" from a) /usr/local/src/incubator-geronimo or b) /usr/local/src/incubator-geronimo/modules/core/src/test In the case of (a), the result of doing "jar -tvf" on the file will be modules/core/src/test/org/apache/geronimo/cache/SimpleInstancePoolTest.java In the case of (b), the result of doing "jar -tvf" on the file will be org/apache/geronimo/cache/SimpleInstancePoolTest.java The question, then, is one of convention / convenience for the comitters - when you guys unjar to do the cvs comitt, which would you prefer? IMHO, option (a) is best because it makes clear where we intend our new file to go. I think Ed also has this opinion. Does that make sense? (It really is a very minor point - I feel embarassed bringing it up ;)) Regards, Gareth On Wed, 13 Aug 2003 14:08:20 +0700, "Jason Dillon" <[EMAIL PROTECTED]> said: > I don't understand the issue here, can someone give me the terse > explanation please. > > --jason > > > On Wednesday, August 13, 2003, at 07:27 AM, Gareth Bryan wrote: > > > My vote would go with from the root of the entire project, but I guess > > it's up to the comitters... > > > > On Wed, 13 Aug 2003 02:21:32 +0200, "Ed Letifov" <[EMAIL PROTECTED]> > > said: > >> Hello Gareth, > >> > >> GB> Put another way, in the jar, do we want:- > >> > >> GB> A) modules/core/src/java/org/apache/... > >> GB> or > >> GB> B) org/apache/... > >> > >> Well, good question. Just send a jar where I've started from the test > >> root directory, which is probably not good at all. > >> > >> I think it should be from the very root of the project. > >> > >> Does anyone has a different opinion? > >> > >> GB> Could you also post the reply to this on the Wiki? > >> > >> Sure, as soon as we decide. > >> > >> -- > >> Best regards, > >> Ed mailto:[EMAIL PROTECTED] > >> > > -- > > Gareth Bryan > > [EMAIL PROTECTED] > > > > -- > > http://www.fastmail.fm - Same, same, but different� > > > -- Gareth Bryan [EMAIL PROTECTED] -- http://www.fastmail.fm - Or how I learned to stop worrying and love email again
