On Wed, Aug 13, 2003 at 02:12:40AM -0000, [EMAIL PROTECTED] wrote: >... > Log: > Updated the Component class to support the JSR77 state model. > Implemented the base behaviour in AbstractComponent > Implemented recursive behaviour in ContainerImpl - but should be moved to > a AbstractContainer class. > Moved create nehaviour to doStart methods > Left destroy methods hanging with todo comments to resolve that issue.
>From this commit message, it sounds like you're mixing semantics in a single commit, which should really be done in multiple commits. By breaking down the commits into logical groups, it makes the commits reviewable. And reviewable commits is, um, "highly desirable" :-) > Submitted by: Greg Wilkins > Reviewed by: Posted to geronimo-dev and coredevelopers.net mailing > lists Let's please keep all discussion about Geronimo on geronimo-dev rather than private mailing lists. [ actually, on other projects, people have raised concerns about "decisions" made off-list, such as in IRC or coding sprints or other gatherings; the best thing to do for those cases is bring the resulting consensus to the list for a closure discussion ] Cheers, -g -- Greg Stein, http://www.lyra.org/
