Dear Committers,
Pls find the following changes for the classes from the
org.apache.geronimo.common package1) A patch to fix 2 bugs in ThrowableHandler 2) A unit test for ThrowableHandler 3) A mock object for ThrowableListener to facilitate testing of ThrowableHandler Regards Sivasundaram Umapathy
Index: ThrowableHandler.java
===================================================================
RCS file:
/home/cvspublic/incubator-geronimo/modules/common/src/java/org/apache/geronimo/common/ThrowableHandler.java,v
retrieving revision 1.4
diff -u -r1.4 ThrowableHandler.java
--- ThrowableHandler.java 16 Aug 2003 15:14:11 -0000 1.4
+++ ThrowableHandler.java 17 Aug 2003 17:18:56 -0000
@@ -56,9 +56,9 @@
package org.apache.geronimo.common;
-import java.util.List;
import java.util.ArrayList;
import java.util.Collections;
+import java.util.List;
/**
* A static singleton that handles processing throwables that otherwise would
@@ -82,7 +82,10 @@
/** Warning throwable. */
int WARNING = 2;
}
-
+
+ // Prevent object construction
+ private ThrowableHandler() {
+ }
/////////////////////////////////////////////////////////////////////////
// Listener Methods //
@@ -176,6 +179,6 @@
* @param t Throwable to be handled.
*/
public static void addWarning(Throwable t) {
- add(Type.ERROR, t);
+ add(Type.WARNING, t);
}
-}
+}
\ No newline at end of file
Tests.jar
Description: application/compressed
