The following comment has been added to this issue:
Author: Jeremy Boynes
Created: Tue, 23 Sep 2003 12:24 AM
Body:
Sorry for the delay
I need a little more time to figure out the threading behaviour (just being
careful).
I did come across a couple of stylistic things that I'd ask you to change:
* no m_ variable names (I know it's not in the coding guide
but nothing else uses that style)
* JavaDoc references (e.g @param matches param name)
Also this (from TimedOutPoolExecutor) struck me as a curious approach:
public void execute(Runnable aTask) throws InterruptedException {
if ( aTask instanceof WorkerContext ) {
super.execute(aTask);
return;
}
throw new IllegalArgumentException("Please submit a WorkWrapper");
}
Why not something like:
public void execute(Runnable aTask) throws InterruptedException {
if ( aTask instanceof WorkerContext == false) {
throw new IllegalArgumentException("Please submit a WorkWrapper");
}
super.execute(aTask);
}
which makes the argument checking a little more obvious?
Finally, can you move this to org.apache.geronimo.connector.work rather than
o.a.g.work as it is part of the connector impl (AIUI)
Sorry to appear picky but we're going to have a big codebase and consistency is
important
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-73
Here is an overview of the issue:
---------------------------------------------------------------------
Key: GERONIMO-73
Summary: WorkManager implementation
Type: New Feature
Status: Unassigned
Priority: Major
Time Spent: Unknown
Remaining: Unknown
Project: Apache Geronimo
Components:
core
Assignee:
Reporter: Gianny DAMOUR
Created: Sat, 6 Sep 2003 1:47 AM
Updated: Thu, 11 Sep 2003 9:01 AM
Description:
This patch contains an implementation of the WorkManager spi. This
implementation delegates the submitted work to three distinct executors - one
for each synchronization policy. Each executor is a thread pool based on the
Doug Lea's PooledExecutor.
The WorkManager and its WorkExecutors are MBeans and are deployed via the
WorkManagement-service.xml file.
During the execution of a work, the WorkListener provided during a the work
submission is duly notified.
A test case yielding the three distinct synchronization policy is also
provided. This test case uses the WorkListener notifications in order to
introspect the status of submitted works.
Gianny
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
