Message: The following issue has been closed.
--------------------------------------------------------------------- View the issue: http://nagoya.apache.org/jira/secure/ViewIssue.jspa?key=GERONIMO-144 Here is an overview of the issue: --------------------------------------------------------------------- Key: GERONIMO-144 Summary: [PATCH] Invalid condition in o.a.g.gbean.jmx.CollectionProxy.removeTarget Type: Bug Status: Closed Priority: Major Resolution: FIXED Project: Apache Geronimo Assignee: Dain Sundstrom Reporter: Ed Letifov Created: Wed, 14 Jan 2004 2:12 PM Updated: Wed, 14 Jan 2004 4:51 PM Description: I think there is a bug in the code (the condition should be reversed and I would suggest dropping containsKey+remove it in favor of remove+check results for being not null): public synchronized void removeTarget(ObjectName target) { // if this is one of our existing targets target... if (!proxies.containsKey(target)) { proxies.remove(target); ProxyMethodInterceptor interceptor = (ProxyMethodInterceptor) interceptors.remove(target); if (interceptor != null) { interceptor.disconnect(); } } } --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://nagoya.apache.org/jira/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira
