Aaron Mulder wrote:
On Sun, 25 Jan 2004, Jeremy Boynes wrote:
That just seems so wrong :-(
On the other hand, the DDBeans themselves are immutable so the only events DConfigBeans receive would pertain to changes in the tree. Provided whatever is mutating the XML notifies all replicas we should be OK.
I have not done anything with the event stuff yet as I could not figure out a need. None of our DConfigBeans register for events and the tool does not modify the structure.
In general, tools can let you edit the standard and server DDs at the same time. So DDBeans aren't really immutable in the sense that getText() (and getText(...)) might change over time. The events are so that if the user changes an EJB name from "Foo" to "Bar", then the server impl can change the ejb-name of the cooresponding DConfigBean from "Foo" to "Bar" (and perhaps the default JNDI name too, you get the idea).
OK - I'd missed the change event (duh) and it makes more sense now :-)
I didn't copy over your impl during the move as it didn't seem to register the listener on the DD node put on the parent and that seemed like a bug.
I don't understand what you mean here. Are you talking about the DDBean impl? If so, that definitely needed to be replaced. If you're talking about the DConfigBean, can you elaborate?
I was talking about the DDBeanImpl - I moved that stuff from core to the new deployment model and the new ones are based on your code but are a new impl. E.g. I replaced the dependency on dom4j with simple DOM manipulation as it appeared the spec didn't need anything complex.
For the provider side, quite a bit needed to change as we completely revamped the configuration stuff. We realized back at ApacheCon that each subsystem (web, ejb, connector, tx, ...) would need its own mechanism to convert its DDs etc. into the runtime GBeans and this would mean that having a single vendor-dd model wasn't going to work - hence the geronimo bit of o.a.g.deployment was a _bad idea._ This meant moving the DConfigBeans out into the pluggables (nova, jetty, ...).
I hope I didn't mess things up too badly. I found it very hard to get my head around the 88 API and would appreciate any comments on what's there.
-- Jeremy
