The problem is that maven plugins also use commons logging, but do not have access to the GeronimoLogFactory class.
IMO it is a very bad idea to force commons logging to use GeronimoLogFactory, though I am sure there is some reason for it.
Currently Log4jService will throw exceptions if the factory is not a GeronimoLogFactory, presumably so that doStart() can change all loggers over to use log4j. In general I believe it is a very bad idea to force one logging system, as we can not assume what then end user will want or need for a logging system.
I suggest we do not force the setting of the log factory inside of GeronimoLogging. If we want this to be set by default, then change the server bootstrap to set this (so that tools like o.a.g.d.Bootstrap do not pick this up, but regular running of the server will). As well as change Log4jService to allow any log factory and only attempt to do GeronimoLogFactory specific fluff, if the factory is indeed and instance.
What is the motivation behind forcing the log factory in the first place?
--jason
On Mar 31, 2004, at 7:42 AM, George Cox wrote:
Hi there,
The HEAD builds successfully with Maven 1.0-rc1-SNAPSHOT, but does not with
Maven 1.0-rc2, failing with this error:
+---------------------------------------- | Executing (default): Geronimo maven deployment plugin | Memory: 18M/45M +----------------------------------------
BUILD FAILED File...... file:/home/gjvc/incubator.apache.org/incubator-geronimo/maven.xml Element... maven:reactor Line...... 180 Column.... 27 java.lang.ClassNotFoundException: org.apache.geronimo.kernel.log.GeronimoLogFactory Total time: 8 minutes 2 seconds Finished at: Wed Mar 31 16:40:21 BST 2004
HTH
-- [gjvc]
PGP.sig
Description: PGP signature
