Patch Set 3:

(1 comment)

> > this test does not belong in msgb_test.c
 > 
 > Where do you think it belongs to?

It tests abis-specific message encoding/decoding, right? I see lapd_test.c has 
some 'abis' in it, but almost looks like this needs a new separate test suite, 
but that again seems a bit overkill... no idea

https://gerrit.osmocom.org/#/c/2165/3//COMMIT_MSG
Commit Message:

Line 17: proper tests and documentation.
add cross reference to openbsc Ib94db414e94a2a1f234ac6f1cb346dca1c7a8be3


-- 
To view, visit https://gerrit.osmocom.org/2165
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib63b6b5e83b8914864fc7edd789f8958cdc993cd
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to