Patch Set 2: Code-Review+1 (3 comments)
https://gerrit.osmocom.org/#/c/2281/2//COMMIT_MSG Commit Message: Line 21: * SCCP: no Global Title Translatio (GTT) yet If you rebase, add the 'n' to Translation https://gerrit.osmocom.org/#/c/2281/2/stp/osmo_ss7_vty.c File stp/osmo_ss7_vty.c: Line 226: vty_out(vty, "cannot create route%s", VTY_NEWLINE); Maybe print the dpc and mask here? IIRC the VTY code will not print the failing rule itself? https://gerrit.osmocom.org/#/c/2281/2/stp/stp_main.c File stp/stp_main.c: Line 53: /* Hack to enable debug logging for all relevant (used?) subsystems */ hehe, it is not that bad ;) -- To view, visit https://gerrit.osmocom.org/2281 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32227b8d3127c6178e4ee45527ce65f69bc7b1e Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-HasComments: Yes
