Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/2407/1//COMMIT_MSG
Commit Message:

Line 7: osmux: Add RTP marker bit support
the commit message could contain some more verbosity. Like when the marker bit 
is actually used in RTP (in DTX), ...


https://gerrit.osmocom.org/#/c/2407/1/include/osmocom/netif/osmux.h
File include/osmocom/netif/osmux.h:

PS1, Line 35: r
doesn't this break backwards compatibility?  The FT has one less bit - ok. But 
the CTR field is now shifted by one bit, rather than having the rtp_m bit in 
place of the former FT bit?


-- 
To view, visit https://gerrit.osmocom.org/2407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0315658159429603f1d80a168718b026015060e9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillm...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to