Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2313/2/src/common/rsl.c File src/common/rsl.c: Line 435: static inline void lapdm_ui_prefix(uint8_t *buf, uint32_t *valid, const uint8_t *current, uint8_t osmo_si, uint16_t len) might make sense to have a comment on top of the function,stating that 'buf' must be caller-allocated and hold len+2 bytes, or 'sizeof(sysinfo_buf_t)? -- To view, visit https://gerrit.osmocom.org/2313 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie97be6ead6ce6d2d425fbfac8429bb90afb95acc Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
