Review at https://gerrit.osmocom.org/2555
lock test: make more robust against timing Remove the stdout printing from the lock_test_help.py, so that there is no problem with a failing test because one output ending up in stdout before the other. So only output the current lock from lock_test.sh. Change-Id: I7fe80a9de88ddee1d66ca5c692948fc9673e4230 --- M selftest/lock_test.ok M selftest/lock_test_help.py 2 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/55/2555/1 diff --git a/selftest/lock_test.ok b/selftest/lock_test.ok index 0e3db40..d7152ac 100644 --- a/selftest/lock_test.ok +++ b/selftest/lock_test.ok @@ -1,8 +1,4 @@ -acquired lock: 'long name' launched first, locked by: long name launched second, locked by: long name -leaving lock: 'long name' -acquired lock: 'shorter' waited, locked by: shorter -leaving lock: 'shorter' waited more, locked by: diff --git a/selftest/lock_test_help.py b/selftest/lock_test_help.py index 7b6dfa1..3e6677b 100644 --- a/selftest/lock_test_help.py +++ b/selftest/lock_test_help.py @@ -14,11 +14,9 @@ fl = FileLock(lockfile_path, name) with fl: - print('acquired lock: %r' % fl.owner) sys.stdout.flush() while os.path.exists(stop_signalling_file): time.sleep(.1) - print('leaving lock: %r' % fl.owner) sys.stdout.flush() touch_file(stop_signalling_file + '.done') -- To view, visit https://gerrit.osmocom.org/2555 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7fe80a9de88ddee1d66ca5c692948fc9673e4230 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>