Patch Set 1: (3 comments)
https://gerrit.osmocom.org/#/c/2589/1/openbsc/src/libmsc/smpp_openbsc.c File openbsc/src/libmsc/smpp_openbsc.c: Line 477: .smpp_status_code = ESME_RSYSERR, > This is C99 structure initialization... which is actually a good idea since So, everywhere else I see this in osmo it's like Neels says. I am going to submit patch set 2 as he suggests. I guess it's not for me to get into a debate about whether or not this C99 struct init should be the way. Is that OK? Line 571: } > (No braces needed around single line.) Done Line 574: gsm411_cause); > This fits into the line, so no need to break it. Done -- To view, visit https://gerrit.osmocom.org/2589 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61fb2d9ef4f2d2eabdc49b53d9966ad328d15e51 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes
