Patch Set 2: Looking at other functions in gtp.c I fail to determine common style. Some functions return 0 on errors, other return -1, yet other return 0 on success but EOF on errors. I can drop this part of the change - it turned out that the error I've been hunting down lies elsewhere so it doesn't really matter. What do you think?
-- To view, visit https://gerrit.osmocom.org/2655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07f1e4246eb178838b7df21946a08a1f60f2084 Gerrit-PatchSet: 2 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-HasComments: No
