Patch Set 5: > > get_p_max_out_mdBm() should be used in this context, with no > fall-back > > See updated revision, not sure if I'm doing it right - is there > some limit on returned value?
the limit implied by physical reality. It's very rare that you would see a value in excess of ~ 46 dBm in reality. So 255 as upper bound is not a constraint, 255 dBm are 31622776601683796426752 Watts of power ;) What I'm slightly more worried about is having a lower bound at 0dBm. While all devices we know/support today have more than 0dBm (1mW) Rf output power, there could very well be (particularly) SDR boards that might have less. > > why are we encoding the power in an IE that is called STATE ?!? > > Because I was unable to find any other suitable attribute among the > 3GPP TS 52.021 ยง9.4 so I've used manufacturer-depended attribute. > Which one would be better to use in this case? I would have just defined a new IEI, like all other BTS vendors do on OML for their own attributes. Look at all the Siemens/BS11 specific values or the many IPA specific values in our header files. "Manufacturer Specific State" is defined as to be used in 6.7.1 state changed event. I think it is intended for an extension on the operational state. So I would go for an int16_t value in an actual manufacturer-specific IE. If you're worried about polluting the global space of IEIs in OML, you could use nested IEs and put all osmocom specific IEs into an "osmocom extension container TLV IE". -- To view, visit https://gerrit.osmocom.org/2786 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f72305bbf1ab74745bffac1bee9f539f5a6de32 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-HasComments: No
