Patch Set 1: Code-Review-2 * OsmoBTS implements only a single BTS within a given OML link so a value != 0x00 is invalid. If this happens, the transmitter of the message must be fixed. * TS 52.021 clearly defines the meaning of 0xff in the bts number:
"If the BTS number is NULL, it shall be understood as referring to all BTSs under the Site Manager." "The value for NULL shall be <FF> in all the cases mentioned above in this subclause." AFAICT, the original code is doing exactyl what it is supposed to do. -- To view, visit https://gerrit.osmocom.org/2846 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d5078ed1239d553c7200ceb5b08b638df33a15 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
