Patch Set 4: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/2812/4/include/osmocom/gsm/protocol/gsm_04_08.h File include/osmocom/gsm/protocol/gsm_04_08.h: Line 1626: GSM48_BCAP_SV_FR = 0, /* GSM FR V1 (GSM FR) */ would be better to keep unrelated comment changes in a separate patch, to be able to immediately see the functional changes in the patch that adds the constants. For example, combine the comment addition patches (from #2811) in one, then have patches that only add the new constants. If it makes sense you could also combine the new constants in one patch, to me it sounds like it does make sense to combine, since all are related to new speech modes? -- To view, visit https://gerrit.osmocom.org/2812 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2835384c855f924332d38f01c73bd1cfdb62549 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
