Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/2916/1/Makefile.am File Makefile.am: Line 8: contrib/dump_docs.py contrib/screenrc-l1fwd contrib/osmo-bts-sysmo.service \ > we're removing sysmobts.service from EXTRA_DIST but keeping the file in the This is the point of this patch, to not remove the file yet so that Openembedded build doesn't fail. It will be removed later as a next step. This way we don't need to coordinate tightly the changes in the 2 places. This is what OE does: install -m 0644 ${S}/contrib/sysmobts.service ${D}${systemd_unitdir}/system/ https://gerrit.osmocom.org/#/c/2916/1/contrib/sysmobts.service File contrib/sysmobts.service: Line 20: Alias=osmo-bts-sysmo.service > I can understand aliasing the new service file as the old name, but adding I think is still nice if someone is already building an image (thus installing sysmobts.service) that they already have the possibility to use osmo-bts-sysmo service. -- To view, visit https://gerrit.osmocom.org/2916 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08615eb625d488603aeb5962ad9f30869c0e77c5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
