Patch Set 2: Code-Review-1 In general, looks fine to me. Especially, it's very usable. But if your commit message says: "Add macros ...", it would be better to only add actual macros to keep it atomic.
The macros integration could be done in a separate one or in a set of commits (prefered for me) with corresponding description. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-HasComments: No
