Patch Set 7: Code-Review-1 (3 comments)
https://gerrit.osmocom.org/#/c/2831/7/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 688: * \param[in] perm_spch value from where the speech codec is derived from 'from where derived from' is incorrect. "perm_spch value the speech codec is derived from" (optionally include "that" or "which" after "value") Line 704: /* Depending on the speech codec type, pick a default codc (codec) Line 725: break; why did you drop the 'default: return -EINVAL'? There should be a default case. (loosely related, callers should check for -EINVAL rc) -- To view, visit https://gerrit.osmocom.org/2831 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I257c972e9fdf0dfe940a8d483447085bd62e50a2 Gerrit-PatchSet: 7 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
