Patch Set 1: Code-Review+1 (2 comments)
https://gerrit.osmocom.org/#/c/3538/1/src/gprs_ms.cpp File src/gprs_ms.cpp: Line 645: /* TODO, use separate table */ I think this TODO can now be removed as you are introducing a separate table? https://gerrit.osmocom.org/#/c/3538/1/src/pcu_vty.c File src/pcu_vty.c: Line 1024: uint8_t mcs1_high = atoi(argv[0]); why have all those local variables first and then another assignment to the respective table? I think it would save some 18 lines of code without affecting readability if we join those lines. Not criticial, but much appreciated if you could change. -- To view, visit https://gerrit.osmocom.org/3538 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9272c337ad6399da4a47cc6e2736e25f24e099d8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.ngu...@nutaq.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
