Patch Set 3: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/3723/3/example/resources.conf File example/resources.conf: Line 16: ciphers: ['a5 0', 'a5 1', 'a5 3'] re-reading this, I get two thoughts: So far we only use the '- item' list format. I would like to use as little diverse a yaml feature set as strictly necessary, to keep the option of moving to a simpler parser one day (i.e. never, but still...). So far we only have config items that have no spaces. I know that it is handy to just write the 'a5 0' thru to a vty config, but I think design wise it's better to add explicit keywords that we validate during config parsing and translate to the actual vty string explicitly. We can then use underscores and drop the need for quoting: bts - label: yada ciphers: - a5_0 - a5_1 - a5_3 (or use a50 like you chose for the scenario naming) Do you agree or am I too pedantic here? -- To view, visit https://gerrit.osmocom.org/3723 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0e368843a6e58bd3eeef36d2c0a7501296f0f3e Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
