Patch Set 4: > just to be clear: This just moves code between files and adjust > whitepsace/formatting, but there are no API/implementation changes? > if yes, +2. "refactoring" can mean many things, that's why I'm > asking.
Yes, it just moves the code. However, the API is slightly changed. I prefixed the public functions with "mgcp_". Also the function do are now called with a connection (conn) and not with &conn->end, but this also does not change the actual implementation. -- To view, visit https://gerrit.osmocom.org/4006 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324 Gerrit-PatchSet: 4 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-HasComments: No
