Patch Set 1: > it seems bad to keep such a large dependency for just one enum and two helpers
Why? What sort of mischief and mayhem it would possibly cause? Besides loosing extra Kb of precious disk space. > the future plan for upcoming libosmo-mgcp is to use the identical header file I'm not following. If the header is planned to be used from several places anyway than why not make it part of a single library and make all the users simply depend on it? Why the need to copy to different repo, than copy at build time etc. We do not copy libosmocore headers into every repo which uses it. How is libosmo-mgcp different? > Replace for_each_line() use in mgcp_client with for_each_non_empty_line() What this have to do with moving headers back and forth? Could it be a separate patch? -- To view, visit https://gerrit.osmocom.org/4010 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8f3fc2b399662a9dbba174e942352a1a21df3f Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-HasComments: No
