Patch Set 1: Code-Review-1 (3 comments)
https://gerrit.osmocom.org/#/c/4095/1/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc File recipes-osmocom/osmo-sgsn/osmo-sgsn.inc: Line 2: HOMEPAGE = "https://osmocom.org/"; link to OsmoSGSN project page? Line 25: PACKAGES =+ "osmo-gbproxy-doc osmo-gtphub-doc osmo-gbproxy osmo-gtphub" there isn't a gtphub service file further above. I guess it doesn't really need to be installed, so drop it here as well? If we install gtphub though, then maybe a .service and examples should also be installed above? Line 38: " (I'm confused, don't we need FILES_osmo-sgsn as well?) -- To view, visit https://gerrit.osmocom.org/4095 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e35660598bfd87917728c521c1fba827e98d68 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
