pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23053 )
Change subject: Remove test backward compatibility with older osmo-* versions ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: -Code-Review > > > > I started doing the change, but I realized I actually prefer getting them > > removed completely. > > > > This allows quickly checking which tests have specific quirks for latest, > > and getting them removed when a new release is done, eg: grep -r \"latest\" > > You can still check whether a specific test suite has backwards compatibility > quirks, depending on what the conditional block contains. I see no problem > with that, so I am not convinced. Why would people need to resurrect > something from the history if we can just keep it? You need to open each file to look at the contents of each if block then, or use a quite more advance grep command to check more stuff -> not handy. Morevoer, following your same reasoning: Why should we keep something if we can resurrect it from history when needed? That's what version controls are for. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f491b58d4576b22c8ff3ab56a7b9e17163a8739 Gerrit-Change-Number: 23053 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 24 Feb 2021 14:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
