osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23053 )
Change subject: Remove test backward compatibility with older osmo-* versions ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-bsc-test/jenkins.sh File ttcn3-bsc-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-bsc-test/jenkins.sh@a24 PS1, Line 24: pre-mscpool-osmo-bsc.cfg This file can be removed now. https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-fr-test/jenkins.sh File ttcn3-fr-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-fr-test/jenkins.sh@a20 PS1, Line 20: # Disable features not in latest yet > I would keep this block empty everywhere instead of removing it completely. > […] I don't have a strong opinion about this. But if we remove it, we keep the boilderplate in each jenkins.sh lower (and such things tend to get inconsistent). Instead we could add an example to README for future reference. https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-sgsn-test/jenkins.sh File ttcn3-sgsn-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-sgsn-test/jenkins.sh@a27 PS1, Line 27: cp osmo-sgsn.latest.cfg "$VOL_BASE_DIR/sgsn/osmo-sgsn.cfg" This file can be removed now. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f491b58d4576b22c8ff3ab56a7b9e17163a8739 Gerrit-Change-Number: 23053 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 25 Feb 2021 11:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
