Patch Set 4: (1 comment)
https://gerrit.osmocom.org/#/c/4231/4/include/osmocom/msc/Makefile.am File include/osmocom/msc/Makefile.am: Line 70 The build error you got was so obvious. In German we would say "Mit Anlauf gegen die Wand". Let me stretch the point of cost of clean-ups. I think the app should not install header files (it doesn't have a plugin interface and will never have one), libraries should be in other repositories. But either one gets it right or people waste their time on something not urgent and not important. You spent at least 30min on it, I spent 10min on it, now neels will spent time on it. Is this the _best_ we could have used our time? -- To view, visit https://gerrit.osmocom.org/4231 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269 Gerrit-PatchSet: 4 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
