laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23378 )
Change subject: filesystem: be more strict in method add_file() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/23378/1/pySim/filesystem.py File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/23378/1/pySim/filesystem.py@152 PS1, Line 152: if child.name[0:3] != "DF." and child.name[0:3] != "EF." and child.name[0:4] != "ADF.": I wouldn't enforce this name prefix. I think it's more a convention than "law". I also thin it is legitimate for files not to have a human-readable name. Let's say we encounter some card model with some proprietary files of which we don't know the name. The check for the FID looks reasonable to me. However, as the FID is 16bits, I'm not sure why we accept any length != 4 hex nibbles? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I096907285b742e611d221b03ba067ea2522e7e52 Gerrit-Change-Number: 23378 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 16 Mar 2021 17:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
