fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18599 )
Change subject: abis_nm: properly warn about unknown / not supported features ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18599/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/18599/3//COMMIT_MSG@12 PS3, Line 12: Vice versa, when some BTS feature is considered as supported : by the BSC, but a BTS reports that it is not, is definitely : a problem that requires some attention. Report this as ERROR. > ping? Sorry for very slow reply. I am now trying to remember the context and trying to understand your question. This change itself is rather cosmetic: we basically make osmo-bsc print something that is a bit easier to understand when the feature vectors are different. AFAIU, you're against using LOGL_ERROR for features which the BSC does expect, but the BTS does not support? In general, I agree, it's not an error. I will change it to NOTICE and will also remove "Please fix", because it's not a bug or something than can be easily fixed in code / configuration file. Do you agree? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2f925bcdb010cb10d074bf7c82619e3ae1f8818b Gerrit-Change-Number: 18599 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sun, 04 Apr 2021 16:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
