laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23620 )
Change subject: cardem: use USART timeout for waiting time ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/apps/cardem/Makefile File firmware/apps/cardem/Makefile: https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/apps/cardem/Makefile@3 PS1, Line 3: tc_etu tc_etu.c here is only needed for non-simtrace boards. We should probably compile it only conditionally, unless we move away from tc_etu altogether. https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/apps/cardem/main.c File firmware/apps/cardem/main.c: https://gerrit.osmocom.org/c/simtrace2/+/23620/1/firmware/apps/cardem/main.c@168 PS1, Line 168: #if 1 looks like an unrelated change -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibcb2c8cace9137695adf5fb3de43566f7cfb93b5 Gerrit-Change-Number: 23620 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tsaitgaist <kre...@sysmocom.de> Gerrit-Comment-Date: Sun, 04 Apr 2021 18:09:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
