Hello Jenkins Builder, laforge,

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/pysim/+/23631

to look at the new patch set (#2).

Change subject: Use zero padding for EF['ACC'] field
......................................................................

Use zero padding for EF['ACC'] field

The ``EF_ACC`` field defines the access control class (ACC)
for a subscriber.

Without this patch, the implementation adds padding 1 towards
the most significant bits if the input is shorter than 2 bytes.

However, it should be padded with 0, otherwise additional ACCs
are allocated to the subscriber. (Probably only a single bit
shall be set to 1)

Excerpt from [ETSI TS 131 102, 
4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf):

```
EF_ACC: Two bytes: B1, B2

B1.b8...B1.b4: high priority users (class 15...11)
B1.b3: always 0
B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be 
evenly distributed across subscribers
```

**Legend:** Byte X, bit Y: BX.bY


Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9
---
M pySim/cards.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/23631/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23631
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9
Gerrit-Change-Number: 23631
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Falkenberg <robert.falkenb...@tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: newpatchset

Reply via email to