fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20290 )
Change subject: generate_ma_for_ts: check num_cell_arfcns to guarantee no out-of-bounds access ...................................................................... Patch Set 1: Code-Review-2 So, I ended up spending more time on it and taking a more radical approach: https://gerrit.osmocom.org/c/osmo-bsc/+/23645 [hopping] vty: ensure no duplicate hopping ARFCN entries [NEW] https://gerrit.osmocom.org/c/osmo-bsc/+/23646 [hopping] generate_cell_chan_list(): make some pointers const [NEW] https://gerrit.osmocom.org/c/osmo-bsc/+/23647 [hopping] gsm48_send_rr_ass_cmd(): use Cell Channel Description from SI1 [NEW] https://gerrit.osmocom.org/c/osmo-bsc/+/23648 [hopping] generate_ma_for_ts() returns no meaningful value [NEW] https://gerrit.osmocom.org/c/osmo-bsc/+/23649 [hopping] Rework generation of Cell/Mobile Allocation [NEW] https://gerrit.osmocom.org/c/osmo-bsc/+/23650 [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again [NEW] TL;DR, the idea is to mitigate the possibility of having more than 64 ARFCNs in the Channel Allocation during the configuration, rather than surprising the user at run-time. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ee8e8b4ba5e16b955685ba42bd58dc2ea08720f Gerrit-Change-Number: 20290 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Assignee: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Tue, 06 Apr 2021 03:04:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
