osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23508 )
Change subject: stat_item: make value ids item specific ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c File src/stat_item.c: https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c@279 PS1, Line 279: LOGP(DLSTATS, LOGL_DEBUG, "osmo_stat_item_discard_all is deprecated"); > INFO? Done https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c@280 PS1, Line 280: return 0; > You may want to call osmo_stats_discard_all() internally here? It doesn't call osmo_stats_discard_all() here, because osmo_stats_discard_all() uses item->stats_next_id. If there is code outside of libosmocore that uses the stat_item API directly (without stats API), it must store its own item-specific next_id outside of osmo_stat_item (see commit message). https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stats.c File src/stats.c: https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stats.c@715 PS1, Line 715: if (!have_value) { > You can drop have_value (which is not an int anymore btw): […] have_value is also used further below, so it can't be dropped. if (!have_value && !srep->force_single_flush) You are right with "is not an int". Since this is unrelated to this patch: https://gerrit.osmocom.org/c/libosmocore/+/23651 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie65dcdf52c8fc3d916e20d7f0455f6223be6b64f Gerrit-Change-Number: 23508 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 06 Apr 2021 10:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
