laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/23689 )

Change subject: pySim-shell: allow generic USIM/ISIM cards to be used
......................................................................


Patch Set 1:

> Patch Set 1:
>
> This may be a bit hackish, but comments are welcome.

I would approach this differently: Have a proper generic card type at the 
pySim/cards.py level.  One that doesn't do ATR matching to detect some very 
specific card, but one that tries to identify a USIM by what applications are 
on the card. Could later be extended to detecting classing SIM if only CLA=A0 
works and DF.TELECOM + DF.GSM are selectable


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/23689
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie1fa42400d236928659a7e5d34225487161d4b83
Gerrit-Change-Number: 23689
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Sat, 10 Apr 2021 09:39:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to