fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23753 )
Change subject: SRVCC: Parse Last Used E-UTRAN PLMN Id in Handover Request ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/23753/6/src/osmo-bsc/handover_fsm.c File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23753/6/src/osmo-bsc/handover_fsm.c@439 PS6, Line 439: TLVP_VAL > That's already being checked by tlv_parse with > gsm0808_old_bss_to_new_bss_info_att_tlvdef() above. Ok, good to know. Though, I would still prefer to see TLVP_PRESENT when we check presence and TLVP_VAL when we get a pointer. This is not critical, but semantically looks more readable. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia5008f11a4c36ef8085a2037d4abddd131086e6e Gerrit-Change-Number: 23753 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 19 Apr 2021 15:43:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
