Patch Set 2: (5 comments)
https://gerrit.osmocom.org/#/c/4311/2/src/ctrl.c File src/ctrl.c: Line 119: do { \ > This looks pretty generic. Would it make sense to put it into libosmoctrl i would indeed; shall we move it now? Line 156: /* not used yet */ > Shouldn't it belong to separate patch? I first wrote this and then figured that no-one is using these values anyway. Instead of deleting and having to figure it out again later, it would be nice to just keep it ready. ok with you? Line 224: > whitespace thx Line 272: > again thx again :) Line 307: ... -- To view, visit https://gerrit.osmocom.org/4311 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50 Gerrit-PatchSet: 2 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
